-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC7159 section-4 #26
Comments
The meaning of SHOULD is defined in RFC 2119. For the parser, we could think about a configuration option. Would this help in your case? |
Hi ralfstx, Leaving the decision to the user makes it more versatile, which might be good. The spirit of the issue was in the sense of encouraging no duplicates. Yes, an option to configure the parser would do the trick =) |
Edit: I n00bed and forgot that there is hashing already being done, so except for doing it more it doesn't bring anything new to the table. Performance impact for sure, but not quite as dramatic. Additionally, programmatically ensuring this is not necessary as JSON is not the problem. If someone wrote the files, they could be unit tested and if they were generated by a system, this system should be fixed. I am not against an option, just think this would make terrible defaults to a project that tries "not to get in the way". |
Currently
minimal-json
allows duplicated names, which is contrary to section 4 of RFC7159, which says: The names within an object SHOULD be unique.Other parsers throw an exception. JSON in Java for example throws
The text was updated successfully, but these errors were encountered: