New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Luxon? #15

Open

rallisf1 opened this issue Jul 22, 2022 · 1 comment

Owner

rallisf1 commented Jul 22, 2022

I created a branch that uses Luxon instead of dayjs as I feel it is abandoned by this point, been waiting for v2 for ages.

Please feel free to test it out. I'll merge it into a 1.2.0 and update the readme once I get positive feedback here.

The only "breaking" change is the parsing format which has a few differences. You can lookup a table here.

My main concern is tree-shaking else I'd use momentjs as any sane person.

@treboryx
@TheArctesian

Contributor

treboryx commented Jul 28, 2022

is the output smaller with luxon? because I know dayjs is much smaller than luxon

SH42DE mentioned this issue

Day.js calculation of remaining months is sometimes incorrect #18

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment