-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoped singleton archive #51
Comments
Sorry, my linter does not check on modules, it's a little more... |
I'm not sure I get it. Tell me if you still have any problem and I'll try to help you. |
Hi, I'd to fork your module... if you use a singleton to avoid sequence names repetition then you can't use the same sequence in 2 different DB... and I use your module in 2 cloned DB, to avoid problems with de DBs I used a Map yo define the scope. I've never made a pull request, if You want I can see how and send you my modifications. Best regards. |
I'm having the same issue, I'm returning multiple connections to the same database and each one of them try to register counters and crash. Require a scoped sequence_archive to fix this issue! |
I already fixed it with a map with the connection as the key, tell me if you need it Regards |
Please, feel free to send a PR |
Hi, thanks for the module, I've an issue regarding to differents DB with the same sequence.
Reading your code I could check your archive lib is defined at the beginning of your code, instead of do it in the getInstance method so if you have two DB with the same sequence it return error.
Can you fix it please? It's just move the definition fron the top to inside the getInstance method.
Thanks in advance
The text was updated successfully, but these errors were encountered: