From 0118d4da6f7d565b8327a23ccabe7521d215562a Mon Sep 17 00:00:00 2001 From: ramrudra Date: Mon, 27 Aug 2018 00:29:46 +0530 Subject: [PATCH] #407 Remove application_static from docs --- README.md | 4 ++-- docs/jquery-with-react-on-rails.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5db8a814d..f66aef75f 100644 --- a/README.md +++ b/README.md @@ -196,9 +196,9 @@ Save a change to a JSX file and see it update immediately in the browser! Note, + Note, the following view helpers do the magic to make this work: ```erb - <%= env_stylesheet_link_tag(static: 'application_static', hot: 'application_non_webpack', options: { media: 'all', 'data-turbolinks-track' => true }) %> + <%= env_stylesheet_link_tag(hot: 'application_non_webpack', options: { media: 'all', 'data-turbolinks-track' => true }) %> <%= env_javascript_include_tag(hot: ['http://localhost:3500/vendor-bundle.js', 'http://localhost:3500/app-bundle.js']) %> - <%= env_javascript_include_tag(static: 'application_static', hot: 'application_non_webpack', options: { 'data-turbolinks-track' => true }) %> + <%= env_javascript_include_tag(hot: 'application_non_webpack', options: { 'data-turbolinks-track' => true }) %> ``` ## Testing diff --git a/docs/jquery-with-react-on-rails.md b/docs/jquery-with-react-on-rails.md index b37bca643..76ae1afd5 100644 --- a/docs/jquery-with-react-on-rails.md +++ b/docs/jquery-with-react-on-rails.md @@ -2,7 +2,7 @@ jQuery and jQuery-ujs are not required within `app/assets/javascript/application.js` and have been moved under`/client` and are managed by npm. The modules are exposed via entry point by [client/webpack.client.base.config.js](client/webpack.client.base.config.js) and, for `jquery-ujs`, in the [client/webpack.client.rails.build.config.js](client/webpack.client.rails.build.config.js) and the [client/webpack.client.rails.hot.config.js](client/webpack.client.rails.hot.config.js). -In `application_non_webpack.js` and `application_static.js.erb`, it's critical that any libraries that depend on jQuery come after the inclusion +In `application_non_webpack.js`, it's critical that any libraries that depend on jQuery come after the inclusion of the Webpack bundle. Please refer to [Considerations for jQuery with Rails and Webpack](http://forum.shakacode.com/t/considerations-for-jquery-with-rails-and-webpack/344) for further info.