Bump envtest to 1.32 #547
Merged
Bump envtest to 1.32 #547
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkatgofurov7
previously approved these changes
Jan 7, 2025
furkatgofurov7
added
area/dependency
controlplane/internal/controllers/rke2controlplane_controller_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
bumpenvtest
branch
from
2ea93b8 to
10e0d36
Compare
Danil-Grigorev
approved these changes
Jan 8, 2025
anmazzotti
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumping envtest to v1.32 and setting a timeout in one test case prevents flakes we see in CI
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #417
Special notes for your reviewer:
Checklist: