Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standartize env variable in all documentation #545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented Jan 7, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #513

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev added the kind/documentation Improvements or additions to documentation label Jan 7, 2025
@alexander-demicev alexander-demicev marked this pull request as ready for review January 7, 2025 14:40
@alexander-demicev alexander-demicev requested a review from a team as a code owner January 7, 2025 14:40
furkatgofurov7
furkatgofurov7 previously approved these changes Jan 7, 2025
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are bunch of references from the docs which are impossible to check them all. Looks good, we can fix small issues if we missed anything iteratively in the future.

Danil-Grigorev
Danil-Grigorev previously approved these changes Jan 8, 2025
anmazzotti
anmazzotti previously approved these changes Jan 8, 2025
salasberryfin
salasberryfin previously approved these changes Jan 8, 2025
@furkatgofurov7
Copy link
Contributor

@alexander-demicev there is a commit signing problem, can you please fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Finish standardizing env names used across examples
5 participants