Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Labels are not applied #517

Open
swarren83 opened this issue Dec 10, 2024 · 1 comment
Open

Additional Labels are not applied #517

swarren83 opened this issue Dec 10, 2024 · 1 comment
Labels
kind/bug Something isn't working priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.12.0

Comments

@swarren83
Copy link

What happened:
When specifying additional labels on the RKE2ControlPlane object, these labels are not applied to the resources owned by the RCP.

What did you expect to happen:
Machine resources created by RCP only receive the following labels:

  labels:
    cluster.x-k8s.io/cluster-name: my-awesome-cluster
    cluster.x-k8s.io/control-plane: ''

How to reproduce it:
Add labels under metadata.labels on the RCP:

foo: bar
mylabel: true

Check Machine owned by RCP and check metadata.labels, only the labels referenced above will be added.

Anything else you would like to add:
This is affecting MachineHealthChecks created from a Cluster that is using spec.topology and ClusterClass to create a CAPI Cluster. topology.cluster.x-k8s.io/owned: '' label is expected to be on the Machine or any RCP owned resources but is not getting propagated down.

Environment:

  • capi provider version: v1.8.4
  • rke provider version: v0.8.0
@swarren83 swarren83 added kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2024
@swarren83
Copy link
Author

This is related to the following lines of code:
https://github.com/rancher/cluster-api-provider-rke2/blob/main/pkg/rke2/control_plane.go#L226C1-L233C1

@swarren83 swarren83 mentioned this issue Dec 27, 2024
Open
@alexander-demicev alexander-demicev added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2025
@alexander-demicev alexander-demicev added this to the v0.12.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
2 participants
@swarren83 @alexander-demicev