bootstrap: switch to chrony for ignition config #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leap/SLEMicro don't include ntpd so the current approach doesn't work
|
While making these changes I also noticed that the ntp.enabled flag doesn't seem to work (for the cloud-init and ignition cases) - I didn't try to fix that here as the flag seems largely redundant, but it may warrant a follow up issue? |
Yes please, thanks! |
furkatgofurov7
approved these changes
Sep 12, 2024
Danil-Grigorev
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Hi @hardys, thanks for the fix! Would you be fine to rebase on main? We suspect the failures in CI are not related to this PR and it should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leap/SLEMicro don't include ntpd so the current approach doesn't work
kind/bug
What this PR does / why we need it:
Currently the
ntp.serversAPI provided e.g byRKE2ControlPlanedoes not work for Leap/SLEMicro, because chrony is used not ntpd as currently configured.Fixes #430
Checklist: