Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster-template-0.0.1.tgz and index.yaml #17

Open
lindhe opened this issue Aug 28, 2023 · 0 comments · May be fixed by #18
Open

Remove cluster-template-0.0.1.tgz and index.yaml #17

lindhe opened this issue Aug 28, 2023 · 0 comments · May be fixed by #18

Comments

@lindhe
Copy link

lindhe commented Aug 28, 2023

I tried installing this chart in Rancher 2.7.5 after removing the tgz and index files, and it seems like it works fine without them. Therefore, I think they should be removed. Mostly because having a binary fine in Git like that is bad, but also because it will be clearer to the end user what one needs to modify or not when using these examples.

https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/cluster-template-0.0.1.tgz

https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/index.yaml

lindhe pushed a commit to lindhe/cluster-template-examples that referenced this issue Aug 28, 2023
@lindhe lindhe linked a pull request Aug 28, 2023 that will close this issue
lindhe added a commit to lindhe/cluster-template-examples that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant