Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting: Null values are at top of list when in descending order #12312

Open
yonasberhe23 opened this issue Oct 21, 2024 · 5 comments
Open

Sorting: Null values are at top of list when in descending order #12312

yonasberhe23 opened this issue Oct 21, 2024 · 5 comments
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Milestone

Comments

@yonasberhe23
Copy link
Contributor

yonasberhe23 commented Oct 21, 2024

Setup

  • Rancher version: v2.10
  • Rancher UI Extensions:
  • Browser type & version: FF, Chrome

Describe the bug
Null values are at top of list when in descending order.

To Reproduce

  1. as Admin, go to users and auth > users
  2. create 2 users (user1 and user2)
  3. log in as user2 (last login should be populated for user2)
  4. log back in as Admin user, go to users and auth > users
  5. sort by last login in descending order
  6. notice user1 (with null value for last login), is on top of the list

Result
Null values are at top of list when in descending order.

Expected Result
Null values should be at the bottom when in descending order (highest to lowest).
Null values should be at the top when in ascending order (lowest to highest).

Screenshots

Screen.Recording.2024-10-21.at.11.12.22.AM.mov

Additional context

@richard-cox
Copy link
Member

Linking #9782, especially #9782 (comment) (any short term fixes will be undone when vai does sorting)

@gaktive gaktive added this to the v2.11.0 milestone Oct 25, 2024
@IsaSih
Copy link
Contributor

IsaSih commented Oct 25, 2024

Linking #10821

@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

Holding off filing a back port until we know if #9782 is needed since that's not part of <2.11 at present.

@richard-cox
Copy link
Member

I would suggest we do not do this, as per comment above (linking to another comment)

@gaktive
Copy link
Member

gaktive commented Dec 4, 2024

Server-side pagination may address this once it lands so holding on this for now. @richard-cox to pass this to QA to test once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Projects
None yet
Development

No branches or pull requests

5 participants