Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research the existing sorting capabilities in the UI, find out what needs to be shifted to Steve #6509

Closed
catherineluse opened this issue Jul 26, 2022 · 3 comments
Milestone

Comments

@catherineluse
Copy link
Contributor

catherineluse commented Jul 26, 2022

In order to load fewer resources in the UI, the UI will need paginated results from Steve, and in order to preserve the ability to sort lists of resources while also having pagination, Steve will need to sort the results on the server side before sending a page to the UI.

There is a backend issue about adding the sorting capabilities to Steve rancher/rancher#38427, but we still need to update it with a list of all the specific sorting features that we need to be added to Steve.

We should take time to:

  • Go through our list views and make a list of the columns that allow sorting.
  • Take note of which columns are calculated with computed properties, especially expensive computed properties that require the UI to loop over a list of resources. If we find expensive computed properties, we should look into having Steve provide them along with the original resource list.
  • Take note of columns calculated with expensive getters in the resource models, for the same reason as above.
  • Take note of columns that are calculated with JSONPath and look into replacing those with functions because functions are faster.
@catherineluse catherineluse changed the title Research the existing sorting capabilities in the UI Research the existing sorting capabilities in the UI, find out what needs to be shifted to Steve Jul 26, 2022
@nwmac nwmac added this to the v2.7.0 milestone Jul 28, 2022
@nwmac nwmac added the kind/tech-debt Technical debt label Jul 29, 2022
@gaktive
Copy link
Member

gaktive commented Aug 22, 2022

We may push this out until the backend comes up with their own pagination. For 2.7.0, we'll have our own UI implementation and we'll learn more about what needs to be done there. I'll link to the other ticket once I find it.

@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Aug 30, 2022
@gaktive gaktive modified the milestones: v2.7.2, v2.7.1 Oct 26, 2022
@gaktive gaktive assigned ghost Oct 26, 2022
@gaktive
Copy link
Member

gaktive commented Oct 26, 2022

@Sean-McQ's work on the web worker along with backend work for pagination makes this a duplicate of sorts, but this may be something that is validated once #6541 and #5997 are done.

@catherineluse
Copy link
Contributor Author

Closing as a duplicate since #6541 covers the same topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants