Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails due to change in behaviour in rancher-webhook #62

Open
alexandreLamarre opened this issue Jan 18, 2024 · 0 comments
Open

CI fails due to change in behaviour in rancher-webhook #62

alexandreLamarre opened this issue Jan 18, 2024 · 0 comments

Comments

@alexandreLamarre
Copy link
Contributor

Describe the bug

In this commit from a while back:

rancher/webhook@47a27e5#diff-d5ef5135963461ac21aa742cdf581fa0e15e6f760386ca28074a43901301d311R60

new behavior was introduced for handling project admission

if len(values) < 2 {
return nil, fmt.Errorf("unable to retrieve project id from annotation, too few values")
}

This causes our CI definitions that use the old assumptions to fail, see

kubectl create namespace e2e-hpo || true
kubectl label namespace e2e-hpo field.cattle.io/projectId=p-example --overwrite
sleep "${DEFAULT_SLEEP_TIMEOUT_SECONDS}"

and in prometheus federator https://github.com/rancher/prometheus-federator/blob/1edea93ad2496a8837e4ce78abebac60a14d9e47/.github/workflows/e2e/scripts/create-project-namespace.sh#L9-L11

To Reproduce

Run the script ./.github/workflows/e2e/scripts/create-project-namespace.sh

Expected Result

We need to update the CI/ helm project operator to use this new webhook handling as it is the default in newer kubernetes distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants