RFC Feedback Fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For backporting - I will cherrypick bd1b35b and uniquely bump each branch's kubectl versions as they all differ. |
jbiers
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, this corrects an oversight I left in place where I was simply adding kubectl binaries to the base kuberlr image. However the optimal method was to fetch the kuberlr binary and add it into an image we compose. So the end result is a lot more like what we do in
rancher/kubectlandrancher/shelltoday - which was always the end goal.Also I bumped the kubectl versions that have been updated since the RFC review process started. Long term these will be bumped by renovate or similar automations.