Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scaling Flaky Tests #1113

Closed
caliskanugur opened this issue Jan 18, 2024 · 2 comments
Closed

Fix Scaling Flaky Tests #1113

caliskanugur opened this issue Jan 18, 2024 · 2 comments
Assignees

Comments

@caliskanugur
Copy link
Member

caliskanugur commented Jan 18, 2024

Static custom scaling tests have multiple fail points and cause inconsistent failures that make it hard to debug or diagnose the issues:

  • Wait/watch timeouts on the cluster active state and node roles ready state 1
  • Clusters get into an error state and it's not the case for manual, either while deleting or adding the nodes
  • We have ETCD and CP separated pools example on docs, but static runs add ETCD and CP as a single node, which might be also related to this

Additionally, we need to consider redesigning:

  • Static tests require configuration input, and as these are static tests, they shouldn't need user inputs
  • While running the whole suite, the dynamic input test will also run, we need a logic to skip these if the input isn't given like the current provisioning tests.

We need to consider redesigning, enhancing, and possibly overwriting these tests. Especially the static tests where we run them on release tests - pushed the sign-off date at least a full day.

Footnotes

  1. We need to consider redesigning nested wait/watch part both for RKE1 and RKE2/K3s. This should be redundant for most of the test designs. Is it an exceptional usage where we need to block the thread twice?

@caliskanugur caliskanugur changed the title Fix Custom Scaling Flaky Tests Fix Scaling Flaky Tests Jan 18, 2024
@rancher rancher deleted a comment from siddhantdange Jan 24, 2024
@markusewalker
Copy link

markusewalker commented Mar 28, 2024

Rancher PRs
2.9: rancher/rancher#44946

Shepherd PRs
2.9: rancher/shepherd#134
2.8: rancher/shepherd#141
2.7: rancher/shepherd#142

@markusewalker
Copy link

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants