Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Add custom ingress for gitea #608

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

This PR adds an option to set up a custom ingress object for Gitea. We need an ingress for every service we want to expose to the local host on Mac.
Setting up Gitea ingress is enabled by setting an e2e flag, we'll rethink this approach along with other flags as a part of #603.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev requested a review from a team as a code owner July 19, 2024 15:28
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev alexander-demicev merged commit 0d54e6f into rancher:main Jul 21, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the giteaingress branch July 21, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants