Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in time estimation printed in run_progress.txt #7

Open
pjuda opened this issue Nov 6, 2021 · 2 comments
Open

Bug in time estimation printed in run_progress.txt #7

pjuda opened this issue Nov 6, 2021 · 2 comments

Comments

@pjuda
Copy link
Member

pjuda commented Nov 6, 2021

The time estimation is working strangely. run_progress.txt example:

RUN PROGRESS SUMMARY
--------------------

  Status
    n_mod       =   49238 /   50000
    [--------------------------------------- ]  98%

  Diagnostics
    ne(L)       =       1.0
    ne(w_hd)    =       1.0
    ne(w_pred)  =       1.0

  Computed or Predicted
    n_cmp       =   49238
    n_prd       =       0
    n_prior     =    1000

  Time
    T_el        =   26[h]  1[m] 19.29[s]
    T_prior     =    0[h] 23[m] 22.57[s]
    T / mod     =    0[h]  0[m]  1.87[s]
    T_tot       =   26[h]  1[m] 44.78[s]

If I understand correctly, T_tot should give the total time estimation. A simple calculation T_el + (50000-49238) * T/mod does not equal T_tot

@pjuda
Copy link
Member Author

pjuda commented Nov 6, 2021

This is probably related to the new feature allowing to sample from prior before running popex. T_prior was introduced and there was a correction to avoid counting this time for T/mod estimation, but it might have broken time calculations otherwise. To be checked.

@pjuda
Copy link
Member Author

pjuda commented Nov 6, 2021

Should be easy to fix, consider this run_progress.txt:

RUN PROGRESS SUMMARY
--------------------

  Status
    n_mod       =   50000 /   50000
    [----------------------------------------] 100%

  Diagnostics
    ne(L)       =       1.0
    ne(w_hd)    =       1.0
    ne(w_pred)  =       1.0

  Computed or Predicted
    n_cmp       =   50000
    n_prd       =       0
    n_prior     =    1000

  Time
    T_el        =   21[h]  9[m] 49.91[s]
    T_prior     =    0[h] 21[m] 14.02[s]
    T / mod     =    0[h]  0[m]  1.50[s]
    T_tot       =   20[h] 48[m] 35.89[s]

T_tot + T_prior = T_el, so it should be sufficient to add T_prior to T_tot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant