Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DME 1.0.0 #57

Merged
merged 2 commits into from
May 22, 2024
Merged

Merge DME 1.0.0 #57

merged 2 commits into from
May 22, 2024

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Mar 23, 2024

This "merges" everything from DME 1.0.0. Hooking works on Linux, reading and writing bytes works via usual sudo perms. Haven't tested on any other OS.

Anything that involved QT has been slightly modified: std::strings were used in favour of QStrings, and the DolphinAccessor that referenced SConfig now directly assigns the default value.
DME GUI also supported changing MEM1 and MEM2 via the settings. Dunno if we need this, currently it uses the hardcoded values.

Current issues:

  • conflicts with the get_status PR

Relevant changelog from what I gathered (may be missing a few):

  • Add null pointer checks in DolphinAccessor
  • Feature: Specify MEM1/MEM2 Regions / Fix compatibility with Dolphin MEM Override
  • Add setting for configuring the threshold to show scanned values in table
  • Naming: Dolphin-memory-engine -> dolphin-memory-engine for consistency
  • Remove primary cache
  • MacOS Support
  • Add the --dolphin-process-name command-line option. The [undocumented] DME_DOLPHIN_PROCESS_NAME environment variable can be used alternatively.

@henriquegemignani
Copy link
Member

The custom MEM1 and MEM2 sizes I'm fine with being hardcoded, but could maybe later expose a way to let users try to hook with different values.
All I wish from it is being able to in multiworld, handle people using custom memory sizes automatically. But if they'll need to provide some configuration then it's not useful.

@Miepee
Copy link
Contributor Author

Miepee commented Mar 24, 2024

Would be nice, but dolphin has a big fat "Enabling memory override will make many games completely unplayable" warning anyway, so I dont care too much about it personally lol

@abso1utezer0
Copy link

Would be nice, but dolphin has a big fat "Enabling memory override will make many games completely unplayable" warning anyway, so I dont care too much about it personally lol

Some debug versions of games require higher amounts of memory for the game to boot

@Miepee
Copy link
Contributor Author

Miepee commented Mar 27, 2024

Interesting, thanks for the info

@henriquegemignani henriquegemignani merged commit 8a1d0a6 into randovania:main May 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants