Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination and logging fixes #183

Closed
wants to merge 3 commits into from
Closed

Pagination and logging fixes #183

wants to merge 3 commits into from

Conversation

ChipWolf
Copy link

fixes #119, fixes #182

  • Added pagination to the users.list and channels.list functions
  • Ensured nested traceback to console when not using Sentry
  • Repaired the logging handler to account for the default handler causing the intended handlers not being initialized and config missing from the namespace

@ChipWolf
Copy link
Author

Dropped below 70% to 69% coverage there, hence the build fail.
I'll look at adding more tests.

jdelic added a commit to optile/destalinator that referenced this pull request May 21, 2020
@jdelic
pull in pagination support from randsleadershipslack#183
a4e2288
@h3h
Copy link
Member

h3h commented Mar 1, 2021

A long line of neglected PRs. 😬 Sorry.

I think we’ve implemented these changes since, though.

@h3h h3h closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ChipWolf @h3h