Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship class instance variable isn't thread safe #313

Open
armyofgnomes opened this issue Mar 28, 2014 · 8 comments
Open

Relationship class instance variable isn't thread safe #313

armyofgnomes opened this issue Mar 28, 2014 · 8 comments
Labels
Done in caxlsx This has already been solved in the caxlsx fork.

Comments

@armyofgnomes
Copy link

If you generate reports in multiple threads, they will validate properly, but the relationship ids will be incorrect because it's caching all instances across threads. This will happen if you are using sidekiq workers.

https://github.com/randym/axlsx/blob/master/lib/axlsx/rels/relationship.rb#L11

@xpepermint
Copy link

+1

@lbalceda
Copy link

+1. @armyofgnomes how did you end up working around this?

@armyofgnomes
Copy link
Author

We ended up doing just one worker per instance as a workaround :(

@bradurani
Copy link

We're stuck with this issue too. Any plans to address?

@trautwein
Copy link

We also have this issue and are working around it by using sidekiq-limit_fetch and limiting the queue to 1.

@hqm42
Copy link

hqm42 commented Jul 12, 2019

I just found #477
same fix different diff

@noniq noniq added the Done in caxlsx This has already been solved in the caxlsx fork. label Dec 15, 2019
@noniq
Copy link
Collaborator

noniq commented Dec 15, 2019

This has been fixed in caxlsx: caxlsx/caxlsx#10

@bradurani
Copy link

Thank you! this one has been plaguing us for years :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done in caxlsx This has already been solved in the caxlsx fork.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants