Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a better itnerface to construct upwind DG operators #309

Open
ranocha opened this issue Dec 5, 2024 · 0 comments
Open

Create a better itnerface to construct upwind DG operators #309

ranocha opened this issue Dec 5, 2024 · 0 comments

Comments

@ranocha
Copy link
Owner

ranocha commented Dec 5, 2024

Right now, one can do something along the lines of

D_local = LegendreDerivativeOperator(-1.0, 1.0, 3) # 4 nodes = polynomial degree 3
mesh = UniformPeriodicMesh1D(; xmin, xmax, Nx = 2^5)
D1 = PeriodicUpwindOperators(
    couple_discontinuously(D_local, mesh, Val(:minus)),
    couple_discontinuously(D_local, mesh, Val(:central)),
    couple_discontinuously(D_local, mesh, Val(:plus))
)

However, it would be nice to have a better API based on upwind_operators, e.g., something like

D1 = upwind_operators(D_local, mesh)

The basic question is whether this is the best option or whether passing something like couple_discontinuously would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant