Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several modules (exploits) are badly formatted #19039

Closed
nrathaus opened this issue Mar 31, 2024 · 5 comments
Closed

Several modules (exploits) are badly formatted #19039

nrathaus opened this issue Mar 31, 2024 · 5 comments
Labels

Comments

@nrathaus
Copy link
Contributor

I have created 4 PR to fix tests that are badly formatted (one - python based - includes unused modules):
#19033
#19032
#19031
#19030

@nrathaus nrathaus added the bug label Mar 31, 2024
@h00die
Copy link
Contributor

h00die commented Mar 31, 2024

Are you using black to fix everything automagically?

@nrathaus
Copy link
Contributor Author

I used 'black' on the Python one, I don't know / think 'black' works on Ruby files - does it?

The ruby files i fixed manually - it was some minor (but annoying) indentation issues

@h00die
Copy link
Contributor

h00die commented Mar 31, 2024

Black is python only. It may be wise to create a black config file to mirror as much is the standards overlap (like line length) the ruby one.
For ruby files use rubocop

@nrathaus
Copy link
Contributor Author

nrathaus commented Mar 31, 2024 via email

@adfoster-r7
Copy link
Contributor

I think all the issues are merged now, thanks!

Does it make sense to close this issue now too? 👀

@nrathaus nrathaus closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants