Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] clipping logic fails when padding token is not 0. #59

Closed
uahmed93 opened this issue Jul 15, 2024 · 1 comment
Closed

[BUG] clipping logic fails when padding token is not 0. #59

uahmed93 opened this issue Jul 15, 2024 · 1 comment

Comments

@uahmed93
Copy link
Contributor

in crossfit/backend/torch/loader.py
when padded tokens are other than 0 , seq_length will always be max value.

 seq_length = (frame[sort_key] != 0).sum(axis=1)

because of which clipping logic is failing.
@VibhuJawa VibhuJawa mentioned this issue Jul 31, 2024
Merged
2 tasks
@VibhuJawa
Copy link
Member

Fixed by: #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VibhuJawa @uahmed93