New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New combined TEXT/PDU mode gsmmodem:send_sms blowing up on max_messages argument #4

Open

jwishnie opened this issue Dec 21, 2009 · 4 comments

Labels

Member

jwishnie commented Dec 21, 2009

The combined merge blew away support for this as an oversight.

Member Author

jwishnie commented Dec 21, 2009

These two commits fix:
http://github.com/rapidsms/pygsm/commit/981dfa90ab9c0d978428091377e1586d3b8f1ef1
http://github.com/rapidsms/pygsm/commit/f84f5bae5675193fd75bdc31cfc45bfa11e41d3c

Member

czue commented Dec 21, 2009

Looks good, thanks! If it all works go ahead and push. I like the doc to code ratio....

Member Author

jwishnie commented Dec 21, 2009

Added some error checking on max_message arg and some unit tests:
http://github.com/rapidsms/pygsm/commit/32c46bd153d632232be1e3afd5c067ec234654d9
http://github.com/rapidsms/pygsm/commit/9b7a33b41f889a20ba336c6fa050850f102018bb

Member

czue commented Dec 21, 2009

Cool looks good (again if it works). Also this doesn't quite make the cut, but remember that commits that are only docs and tests don't need review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment