Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading order validator from ERC-1271 to ERC-6492 - required for ERC-4337 #255

Open
MakiBM opened this issue Nov 2, 2023 · 1 comment

Comments

@MakiBM
Copy link

MakiBM commented Nov 2, 2023

I have a question / issue regarding your order validator service:
https://github.com/rarible/ethereum-indexer-public/blob/8061d075baf19ea6bb59fe56820fa8a96cd21a65/order/api/src/main/kotlin/com/rarible/protocol/order/api/service/order/validation/validators/OrderSignatureValidator.kt#L49

Your logic for validating signature is based on ERC-1271. Any chance you could upgrade it to ERC-6492?

Example implementation
https://github.com/AmbireTech/signature-validator

That's a serious business blocker for us as we're implementing accounts as per new ERC-4337. Signer becomes a separate entity and it's not the same as NFT owner / order maker.

All but sell SDK operations (mintAndTransfer, directPurchase, safeTransfer, burn, cancel) are happening in the background via direct eth_sendTransaction calls. The sell happens differently: eth_signTypedData_v4 and then api/orders. We were able to upgrade all eth_sendTransaction logic without any changes on your end but the flow of sell logic makes it harder / impossible for us.

Eventully as a plan b - do we have any way to list NFT for sale without using your API / indexer?

@evgenynacu
Copy link
Member

Thanks @MakiBM
Currently this issue is in the next week's sprint, but at this point we can't give an ETA about it
Will keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants