-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fork of libcamera #178
Comments
The Regarding the If I can clarify anything further, please let me know. |
I am very happy to hear that you intend to merge these changes back upstream again and I can now understand why you have to "deploy" these features before they are merged upstream.
Do you mean using the macro If you need to "deploy" the |
We will update Unfortunately, I don't think the mechanics exist to have |
Are there any further questions regarding this topic? If not, feel free to close this. |
I would still like to keep this open until the |
Resolved as in merged upstream? |
Yes. Is this ok for you? |
Sure. |
Commit 82c5ea2 is the last common commit (i.e. the merge-base) between the upstream
master
branch and yourmain
branch, after which API incompatible controls (rpi::ScalerCrops
) were added in 554b2a5.Having this on the
main
branch suggests that this is now a fork of the upstream project and not temporary work that is supposed to be merged back upstream. Having this API-incompatible change released also supports this view.Could you please elaborate on the strategy behind this? Are you trying to mere these changes into the upstream project (in which case you should probably not release those API-incompatible changes but keep them on a feature branch) or is this now an incompatible fork of libcamera (in which case you should probably rename the project)?
The text was updated successfully, but these errors were encountered: