Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pico_unique_id header needs some updates #1915

Closed
lurch opened this issue Sep 7, 2024 · 2 comments · Fixed by #1942
Closed

pico_unique_id header needs some updates #1915

lurch opened this issue Sep 7, 2024 · 2 comments · Fixed by #1942
Assignees
@peterharperuk
Labels
documentation Improvements or additions to documentation
Milestone
2.1.0

Comments

@lurch
Copy link
Contributor

lurch commented Sep 7, 2024

From reading the comments in unique_id.h (which also appear here ) you might think that pico_get_unique_board_id always returns the ID of the flash chip. However looking at the implementation it looks like that on RP2350 it actually gives you the SYS_INFO_CHIP_INFO (which I think is described in section 5.4.8.17. of https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf ?).
And I guess this also means that you won't get a unique_id of all-0xEE on PICO_NO_FLASH builds for RP2350? 😉
@lurch lurch added the documentation Improvements or additions to documentation label Sep 7, 2024
@peterharperuk
Copy link
Contributor

Yes, it, it uses a value from OTP on rp2350

peterharperuk added a commit to peterharperuk/pico-sdk that referenced this issue Sep 23, 2024
@peterharperuk
Clarify that RP2350 gets its unique id from OTP
6f83725 
Fixes raspberrypi#1915
@peterharperuk peterharperuk mentioned this issue Sep 23, 2024
Merged
@lurch lurch linked a pull request Sep 25, 2024 that will close this issue
Clarify that RP2350 gets its unique id from OTP #1942
Merged
kilograham pushed a commit that referenced this issue Sep 28, 2024
@peterharperuk
Clarify that RP2350 gets its unique id from OTP (#1942)
66335f1 
* Clarify that RP2350 gets its unique id from OTP

Fixes #1915

* Wrap rp2040_specific and rp2350_specific bits
@kilograham kilograham added this to the 2.0.1 milestone Sep 28, 2024
@kilograham
Copy link
Contributor

merged into devleop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterharperuk peterharperuk

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Clarify that RP2350 gets its unique id from OTP peterharperuk/pico-sdk
3 participants
@lurch @kilograham @peterharperuk