Clarify that RP2350 gets its unique id from OTP #1942
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I wonder if this ought to use the |
|
yes, looks like that might be a good idea. |
lurch
reviewed
Sep 25, 2024
| * Get the unique 64-bit device identifier which was retrieved from the | ||
| * external NOR flash device or OTP memory at boot, formatted as an ASCII hex string. | ||
| * Will always 0-terminate. | ||
| * Get the unique 64-bit device identifier formatted as a 0-terminated ASCII hex string. |
There was a problem hiding this comment.
Would "null-terminated" be better than "0-terminated" ?
|
One small quibble but otherwise looks great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1915