Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sara.py line 219, undefined pd_tolf #119

Open
y-mhiri opened this issue Nov 8, 2024 · 1 comment
Open

sara.py line 219, undefined pd_tolf #119

y-mhiri opened this issue Nov 8, 2024 · 1 comment

Comments

@y-mhiri
Copy link
Collaborator

y-mhiri commented Nov 8, 2024

if ntol < niters:
    pd_tolf = pd_tol[-1]
    pd_tol += [pd_tolf]*niters  # no harm in too many

When niters is equal to 1, for all ntol we have ntol >=niters. It results in pd_tolf not being defined raising an error later in the worker. A simple fix would be either changing the condition to ntol <=niters or setting pd_tolf before the condition.

pd_tolf = pd_tol[-1]
if ntol < niters:
    pd_tol += [pd_tolf]*niters  # no harm in too many
@landmanbester
Copy link
Collaborator

Good catch, thanks for reporting. I will add a fix for this to #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants