Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 installation crash #124

Open
AlexKurek opened this issue Dec 14, 2024 · 6 comments
Open

Python 3.12 installation crash #124

AlexKurek opened this issue Dec 14, 2024 · 6 comments
Assignees

Comments

@AlexKurek
Copy link

shadems needs datashape:
Collecting datashape (from datashader<0.16.0,>=0.15.0->shadems==0.5.3->-r /opt/lofar/requirements3.txt (line 38))
datashape is not compatibile with Python 3.12:
blaze/datashape#245

(This is an upstream of tikk3r/flocs#100 (comment)).

@AlexKurek AlexKurek changed the title Python 3.12 crash Python 3.12 installation crash Dec 14, 2024
@o-smirnov
Copy link
Collaborator

Ugh, looks like we need to pin the Python version to <=3.11 until datashape is fixed... Thanks for the report!

@o-smirnov o-smirnov self-assigned this Dec 15, 2024
@AlexKurek
Copy link
Author

AlexKurek commented Dec 15, 2024

I dont think its getting fixed, last commit was ~5y ago.
BTW datashader now supports Python 3.12: https://github.com/holoviz/datashader/releases/tag/v0.16.1

@o-smirnov o-smirnov assigned Athanaseus and unassigned o-smirnov Dec 15, 2024
@o-smirnov
Copy link
Collaborator

Hmmm, I'm confused where datashader<0.16.0 comes from then, we don't have an upper version pin in pyproject.toml. @Athanaseus any idea?

@Athanaseus
Copy link
Member

Hi @o-smirnov ,

This is because the caret (^) in semantic versioning (datashader = "^0.15.0") allows updates within the minor version range for versions below 1.0.0.
Valid versions: 0.15.0, 0.15.1, 0.15.2, etc., up to but not including 0.16.0.

Indeed, 0.16.1 supports Py3.12 and dropped Py3.8.
@AlexKurek please try with issue-124 branch.

Best regards

@AlexKurek
Copy link
Author

I checked, it works:

Collecting git+https://github.com/ratt-ru/shadeMS.git@issue-124 (from -r /opt/lofar/requirements3.txt (line 38))
  Cloning https://github.com/ratt-ru/shadeMS.git (to revision issue-124) to /tmp/pip-req-build-yfwbbl1g
  Running command git clone --filter=blob:none --quiet https://github.com/ratt-ru/shadeMS.git /tmp/pip-req-build-yfwbbl1g
  Running command git checkout -b issue-124 --track origin/issue-124
  Switched to a new branch 'issue-124'
  branch 'issue-124' set up to track 'origin/issue-124'.
  Resolved https://github.com/ratt-ru/shadeMS.git to commit acf3433efda97aefb5cfe3cff4d55114aa9b420c
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'

@o-smirnov
Copy link
Collaborator

Hi @o-smirnov ,

This is because the caret (^) in semantic versioning (datashader = "^0.15.0") allows updates within the minor version range for versions below 1.0.0.

Thanks! I learn something new every day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants