Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to work with React 16 #1

Closed
radufarcas10 opened this issue Dec 19, 2017 · 2 comments
Closed

Upgrade to work with React 16 #1

radufarcas10 opened this issue Dec 19, 2017 · 2 comments
Assignees
@raulmatei
Labels
enhancement

Comments

@radufarcas10
Copy link

radufarcas10 commented Dec 19, 2017 •
edited
Loading

Hi @raulmatei ,

I don't know if this is still a WIP or not, but I'll try anyway. Would you please upgrade the lib to use React 16? I think only changing the import of propTypes from prop-types npm package instead of the react lib should be enough. Not sure though.

Thank you!
@raulmatei
Copy link
Owner

Will do, but please also have in mind that this uses https://github.com/jordangarcia/nuclear-js-react-addons which also has to upgrade React 16+. There seems to be a PR jordangarcia/nuclear-js-react-addons#23 which is not yet merged. Also see: jordangarcia/nuclear-js-react-addons#22

@raulmatei raulmatei self-assigned this Dec 19, 2017
@raulmatei
Copy link
Owner

Version 1.0.0 is on NPM https://www.npmjs.com/package/frux - tests are failing because of nuclear-js-react-addons dependency that is still using PropTypes from React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulmatei raulmatei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raulmatei @radufarcas10