Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACT no longer ending combat #283

Open
quisquous opened this issue May 10, 2022 · 3 comments
Open

ACT no longer ending combat #283

quisquous opened this issue May 10, 2022 · 3 comments

Comments

@quisquous
Copy link

quisquous commented May 10, 2022

There's been a large number of reports in the ACT ffxiv discord starting somewhere around 6.1 saying that combat is no longer ending. I have at least one confirmed person who said that they never clicked the OverlayPlugin "end combat on wipe / out of combat" checkboxes and was solely depending on the ACT encounter timings to end combat. There hasn't been an ACT release in that time, so it seems most likely to be an ffxiv plugin change?

My suspicion is that there is some line flagged by the ffxiv plugin that looks to ACT like combat is continuing even when it is not, and this changed somewhere around the intl 6.1 release changes. I don't have any idea how to debug which lines are causing this, if this is the issue.

@EQAditu
Copy link

EQAditu commented May 13, 2022

ACT's timeout based encounter ending relies upon SetEncounter() being called by the parsing plugin. It's hard from the outside to know what is calling SetEncounter(). Possibly a plugin could check if LastHostileTime updates on each log line parsed to determine if SetEncounter() was called. But during normal combat, this would be most log lines... so you'd have to filter time by when you think the encounter should have ended.

It's an annoying thing for anyone to debug, including Ravahn. We should possibly ask for log contributions where the player knows it is not working properly.

@blacc000
Copy link

blacc000 commented May 13, 2022 via email

@MrKzimir
Copy link

Are you still needing logs to trackdown this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants