Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output of mapping should use the same structure for all datatypes #20

Open
mikima opened this issue Feb 8, 2021 · 0 comments
Open

Output of mapping should use the same structure for all datatypes #20

mikima opened this issue Feb 8, 2021 · 0 comments
Assignees
@bianchimro
Labels
enhancement New feature or request

Comments

@mikima
Copy link
Member

mikima commented Feb 8, 2021

Screenshot 2021-02-08 at 11 57 15

At the moment, dates datatype is noted as:
dimension.dataType.type: 'date'

while for numbers is
dimension.dataType: 'number'

which makes more complex its usage in rendere (e.g. to understand if we should create a numerical or temporal scale).

My proposal is to use the dimension.dataType.type for all the types
@mikima mikima added the enhancement New feature or request label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bianchimro bianchimro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bianchimro @mikima