From 16321126dd150039e4a626a0c57fb87bfe0247d0 Mon Sep 17 00:00:00 2001 From: linbudu599 Date: Thu, 20 Jul 2023 11:42:30 +0800 Subject: [PATCH] chore(rax-swiper): enhance comments --- packages/rax-swiper/src/web/init-swiper.js | 14 +++++++++++--- packages/rax-view/tsconfig.json | 11 ++++++++--- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/packages/rax-swiper/src/web/init-swiper.js b/packages/rax-swiper/src/web/init-swiper.js index d577a885..bb81cc6a 100644 --- a/packages/rax-swiper/src/web/init-swiper.js +++ b/packages/rax-swiper/src/web/init-swiper.js @@ -6,9 +6,17 @@ import { needsNavigation, needsPagination, needsScrollbar } from './utils'; // both support webpack 4 and 5 resolving rule. import 'swiper/swiper-bundle.min.css'; -// TODO: Support SSR in Swiper component of HyperKit -// A temporary solution to prevent swiper.js errors under SSR -document.documentElement.style = document.documentElement.style || {}; +/** + * TODO: Support SSR in Swiper component of HyperKit. + * Temporary solution to prevent swiper.js errors under SSR. + * + * Swiper.js use ssr-window under the hood, which ensure `document` is defined. + * So we need to ensure `document.documentElement` and `document.documentElement.style` only. + */ +if (!document.documentElement?.style) { + document.documentElement = document.documentElement || {}; + document.documentElement.style = document.documentElement.style || {}; +} Swiper.use([Autoplay, Pagination]); function initSwiper(swiperParams) { diff --git a/packages/rax-view/tsconfig.json b/packages/rax-view/tsconfig.json index 4d243e97..dbb7250d 100644 --- a/packages/rax-view/tsconfig.json +++ b/packages/rax-view/tsconfig.json @@ -17,8 +17,13 @@ "noImplicitThis": false, "outDir": "lib", "baseUrl": ".", - "allowSyntheticDefaultImports": true + "allowSyntheticDefaultImports": true, }, - "include": ["src/**/*"], - "exclude": ["node_modules", "lib"] + "include": [ + "src/**/*" + ], + "exclude": [ + "node_modules", + "lib" + ] }