Cinnamon 2.2 and GTK+ 3.14

[dodev]

Hi!

I'm a Mediterranean theme user for a while now and it is by far the cleanest, neatest and sexiest theme out there! Kudos!

But recently I upgraded to cinnamon from 2.0 to 2.2 and it turns out it breaks parts of the Mediterranean wiget and window themes. I checked my version of GTK+ and it's 3.14.1.

Here are some of the things that are broken:

Is there something I can do about this?

[dodev]

I have some CSS skill and I'll try to implement those parts that are different in GTK >= 3.12. I'll send a pull request when I get this done.

[rbrito]

Dear @dodev.

Can you please check if you still have issues with the newest changes that were contributed by @robertpainsi, among other people?

BTW, if you know some CSS, we desperately need some help to refactor and make these themes maintainable.

Once you confirm that this issue is gone, I guess that we can close this bug.

Thanks,

Rogério.

[dodev]

Hi!
The most recent changes committed to this repository did not fix the issues with GTK+ 3.12. I'll give it another try later today when I get back home.

About the maintainability - I have some ideas how this can be achieved. I'll ping you again on this topic.

[robertpainsi]

That would be awesome. Jump in here #19 for information about the refactoring and add your thoughts and improvement ideas. 😸

The gtk3-widget-factory, which shows all kind of ui elements, seems to have the same problem you posted. It can be installed by

sudo apt-get install gtk-3-examples #install
gtk3-widget-factory #run

I added this tool here because it's related to the issue but we should create a wiki page for these type of informaton. ping @rbrito 😼

BTW: Your problem can be resolved by #28 Unfortunately this PR is just a quick and dirty c&p job and it's not tested well nor inspected. It also may change your titlebar edges to round corners.

[dodev]

Hey, Robert!

I've checked out #28 and it solves the transparent background of the title-bar. But the other widget problems are still present.

[robertpainsi]

Ohh, stupid me! Should have put on my glasses 😹
Now I see what the problem is in picture#2. And in picture#3 there are missing checkboxes right?
Let's see if the current refactoring process will fix these problems too.

[dodev]

Yep, the borders of the checkboxes are missing. Other things, that are not rendered correctly with the theme include:

• missing radio button borders
• missing context menu borders
• the new GTK button groups are rendered as separate buttons.
  Here's a screenshot of the widget factory:
  

As far as I understand, in GTK 3.12+ a lot of the widget's class names were changed, which rendered a lot of the CSS rules from Mediterranean* without any matching elements. I was able to fix some of those in my fork (by sneaking in themes that work correctly with the latest versions of GTK), but I'm a man with a notorious lack of self-organization and I haven't achieved much.

The way to go, as I see it, is to create a template (#19) and start migrating the theme 1 rule at a time.

[robertpainsi]

Today I removed all my themes in my /usr/share/themes folder 🙀. First I just wanted to delete all my downloaded themes I don't use anymore... then everything got out of hand and I deleted all of them. 😾 However...

I changed my theme to the White one and opened the widget-factory. I don't have the same problem with the radio buttons. The widgets look different too. In the MediterraneanWhite/gtk-3.0/assets folder you see the used icons for checkboxes and so on. Also the radio button border is in the asset image. So no css border would solve that (the easy way 😸)...

Btw: The MediterraneanWhite theme prints an error

(gtk3-widget-factory:16014): Gtk-WARNING **: Theme parsing error: unity.css:51:10: 'start' is not a valid property name

https://github.com/rbrito/pkg-mediterranean-gtk-themes/blob/master/MediterraneanWhite/gtk-3.0/unity.css#L49
has to be commented out. I won't to fix that for the master yet because I nearly finished my first common merge base stuff thingy 😼