Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to deploy contracts to testnet, mainnet? Jakefile limited to local shard #32

Open
dckc opened this issue Dec 29, 2020 · 9 comments
Open
Assignees

Comments

@dckc
Copy link
Contributor

dckc commented Dec 29, 2020

see rchain-community/rchain-api#79

@dckc
Copy link
Contributor Author

dckc commented Apr 22, 2021

I wonder if we should continue to maintain the Jakefile. I would like us to, but I don't see anybody else digging in to it. It overlaps in functionality almost completely with the shell scripts and it has fallen behind.

@Bill-Kunj
Copy link
Collaborator

@dckc @jimscarver @w2vy
What if we:

  1. refactor the non-UI portions of network selection, deploy, and propose out of participate into reusable js files
  2. port the shell scripts to nodejs using (1)
  3. refactor (2) into reusable js files invoked from the ported scripts in (2)
  4. refactor Jakefile to use (3)

These are each (relatively) small items (think short-duration Issues) providing a positive enhancement to the development environment.
This would also give the non-javascript folks opportunity to learn the required technical skills in small bites.

@dckc
Copy link
Contributor Author

dckc commented Apr 23, 2021

porting the shell scripts sounds good.

I thought I had mostly already done the other parts, but on reflection, perhaps not as much as we should.

@w2vy
Copy link
Collaborator

w2vy commented Apr 24, 2021

Will doing this aid in possible (semi)automated regression testing?
But this may be a different discussion, there are likely other parts needed to validate results of actions by a test script
(I am very Lazy, I hate doing things manually and I will work very hard so I can be Lazy :))

@dckc
Copy link
Contributor Author

dckc commented Apr 24, 2021

Will doing this aid in possible (semi)automated regression testing?

yes, it should.

But this may be a different discussion

right; see #103

@Bill-Kunj Bill-Kunj added this to the October coop voting app milestone Jun 3, 2021
@Bill-Kunj
Copy link
Collaborator

@jimscarver @dckc @David405, I think this is still an issue, or am I daft on this?

@dckc
Copy link
Contributor Author

dckc commented Aug 27, 2021

I don't see a fix for it in https://github.com/rchain-community/rgov/commits/master/Jakefile.js

I don't know how well the Jakefile is maintained. It may be obsolete in favor of the master directory.

@Bill-Kunj
Copy link
Collaborator

@dckc The master directory may be a solution to the overall dilemma. The question I'm trying to get at is whether or not this can be removed from the milestone for https://github.com/rchain-community/rgov/milestone/4.

@dckc
Copy link
Contributor Author

dckc commented Aug 27, 2021

I don't know the scope of milestone/4 very well, but it's hard to imagine that this issue is in the critical path.

@dckc dckc removed this from the October coop voting app milestone Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants