Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt CSV download from submissions view #118

Open
dc2007git opened this issue Jun 12, 2024 · 7 comments
Open

Encrypt CSV download from submissions view #118

dc2007git opened this issue Jun 12, 2024 · 7 comments
Labels
feature New feature or request TODO Not an issue, but a feature to be added

Comments

@dc2007git
Copy link
Contributor

More of a TODO than an issue - but logging here for reference:

image

The download button in the audit cohort view still requires functionality to be integrated. I imagine it should just redownload the same csv as was submitted for that instance.

@dc2007git dc2007git added feature New feature or request TODO Not an issue, but a feature to be added labels Jun 12, 2024
@mbarton mbarton changed the title Delete button in Submissions view functionality Download button in submissions view functionality Jul 18, 2024
@mbarton
Copy link
Member

mbarton commented Jul 18, 2024

To match the security measures of the previous platform we should wrap any downloads in a password encrypted ZIP file. The old platform let you specify your own password but I would prefer we generate a one time password displayed after the download

@mbarton
Copy link
Member

mbarton commented Jul 18, 2024

I think it's important to download literally the same CSV file as was uploaded - so implementing this should be less of an "export" option and more "download what the user uploaded to help debugging"

@mbarton
Copy link
Member

mbarton commented Aug 28, 2024

Implemented in #257

The old system puts any downloads in a password protected ZIP file but we haven't done that for people downloading the CSV files. It seems maybe overkill since they were likely to have submitted the files in the first place.

@AmaniKrayemRCPCH should we password protect the CSV when people download it?

@AmaniKrayemRCPCH
Copy link

Has something similar been implemented in E12? Do they require a password?

@mbarton
Copy link
Member

mbarton commented Aug 28, 2024

I don't think we ever implemented it in E12, there was some discussion late last year rcpch/rcpch-audit-engine#643

Do data uploaders need download access anyway since they had the spreadsheet unencrypted beforehand? If we limit the feature to the NPDA team then I would say we don't need it as we will already store and handle it appropriately.

@AmaniKrayemRCPCH
Copy link

Having looked at our DPIA, we state that any data downloaded by units is password protected, so we need to stick with that.

It's hard to tell how often people are actually exporting their data - it's not in our user event log. Nor can I think of a use case.
Those submitting via CSV will already have their data file, but those submitting via questionnaire won't.

I can get some user perspective at the next dataset and methodology working group or project board meeting?

@mbarton
Copy link
Member

mbarton commented Aug 30, 2024

Yeah this is specifically for downloading the CSV you uploaded, which I think was in the original requirements so the NPDA team could investigate claims that numbers were incorrect.

We haven't implemented data export for people submitting via questionnaire yet.

I can get some user perspective at the next dataset and methodology working group or project board meeting?

That would be very useful thanks, we can use that to guide what we password protect and if we need to give people other than the NPDA team access to download the CSV files

@mbarton mbarton changed the title Download button in submissions view functionality Encrypt CSV download from submissions view Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request TODO Not an issue, but a feature to be added
Projects
None yet
Development

No branches or pull requests

3 participants