Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hack #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add hack #121

wants to merge 2 commits into from

Conversation

littlewhitecloud
Copy link
Contributor

@littlewhitecloud littlewhitecloud commented Oct 15, 2023

fix #97

Hightlightthickness is 0 means the Text widget will not show the highlight border and I agree this, because the border looks ugly.
image
And here is a screenshot that shows the difference between borderwidth=2 and the normal borderwidth, there are 1px black frame in the left and 2px grey frame in the bottom, so I disagree the second.
image
And the relief, here is the screenshot (test with borderwidth=2):
image
I think normal relief is better than the solid, so I think they can set the solid by themself.

So we just need set the highlightthickness=0 as default.
(Of course this is just my option, maybe we can ask Akuli for options.)

@littlewhitecloud littlewhitecloud marked this pull request as ready for review October 15, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hack
1 participant