Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKit Chemical Transformation Node May Have Issues With Intermediate Products #156

Closed
manuelschwarze opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels

Comments

@manuelschwarze
Copy link
Contributor

manuelschwarze commented Nov 19, 2024

Taka Ohshima [email protected] has detected an issue in his workflows related to the RDKit Chemical Transformation node, he wrote:
I am trying to convert a carboxylic acid to an amide with the following reaction smarts.
#6;A:1-! @[#8;H1:3]>>*:1-[#7:3]
However, when I process against a dicarboxylic acid, I get an error message. Also, only one of the carboxylic acids is amide-converted (not all carboxylic acids are processed; I have set Maximum Number Of Reaction Cycle = 100). Attached is a workflow to demonstrate this. QA2024_024_ChemicalTransformation.zip

The problem that @greglandrum identified was the following: The problem is being called because the chemical transformation node is not sanitizing the intermediate molecules. This means that ring information is not being re-generated and Taka's query, which uses ring features, leads to an exception. Adding sanitization will cause some intermediate products to fail, but these are almost certainly going to be removed later anyway when the final products are sanitized.

Bugfix: Instead of sanitizing only the end resulting molecule, we will do this now already for the intermediate products. This will lead to slightly different error messages when sanitization fails, but it will fix issues like the one Taka has reported.

@manuelschwarze manuelschwarze self-assigned this Nov 19, 2024
@manuelschwarze
Copy link
Contributor Author

Fixed in latest version 4.12 (for KNIME <5.3) and 5.2 (for KNIME 5.3+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant