PHP8.2, Attributes and deprecate doctrine #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 25, 2024 16:05
- Require PHP 8.2 or higher - Require PHPUnit 11 - Require pcov extension for code coverage - Add squizlabs/php_codesniffer for code standards - Require symfony/cache for caching - Remove Doctrine Cache and Annotations - Remove laminas/laminas-zendframework-bridge
rdohms
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
@igordeveloper this looks pretty sweet, thanks for the hard work.
From what I see we are ready to go with this, it's a full on new major so we don't need to worry too much.
phpcs.xml.dist
Outdated
| @@ -3,7 +3,6 @@ | |||
| <rule ref="PSR12"/> | |||
|
|
|||
| <file>src</file> | |||
| <file>tests</file> | |||
There was a problem hiding this comment.
I don't necessarily agree with this, but it's fine for now, once I decide to bring this back to the DMS Coding Standard I can address this
rdohms
added
Feature
rdohms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.