perf: map filter -> reduce #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 508 506 -2
Branches 136 145 +9
=========================================
- Hits 508 506 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
为啥改这个，记得 PR body 里都写一下原因，以及修改后的效果。 |
zombieJ
reviewed
Aug 4, 2023
| return null; | ||
| }) | ||
| .filter(node => node); | ||
| return list.reduce((total, dataNode) => { |
There was a problem hiding this comment.
是滴，少遍历一次，这里是递归（就不止少遍历一次了）
这个看标题就看出来了呀。map filter 改成 reduce，少遍历一次。然后这里是递归，就不止少遍历一次了。 |
|
这个标题对不熟悉的人看不出来的，信息量太小了。 |
|
另外这是一个好习惯，写给自己也写给社区其他人。 |
收到🫡 |
其实对于每层，还是少遍历一次。😈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map filter 改成 reduce，少遍历一次。然后这里是递归，就不止少遍历一次了。