feat: support titleRender #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zombieJ
reviewed
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 514 518 +4
Branches 147 140 -7
=========================================
+ Hits 514 518 +4 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Nov 15, 2023
src/TreeSelect.tsx
Outdated
| @@ -438,9 +440,10 @@ const TreeSelect = React.forwardRef<BaseSelectRef, TreeSelectProps>((props, ref) | |||
| // Back fill with origin label | |||
| const labeledValues = values.map(val => { | |||
| const targetItem = rawLabeledValues.find(item => item.value === val); | |||
| const label = treeTitleRender ? treeTitleRender(targetItem) : targetItem?.label; | |||
There was a problem hiding this comment.
这个看起来会把 labelInValue 给误改掉，有 labelInValue 的时候，没有 label 才能改这个。
There was a problem hiding this comment.
这个看起来会把
labelInValue给误改掉，有labelInValue的时候，没有label才能改这个。
是我理解的这样吗：
let label = targetItem?.label;
// Ensure that when labelInValue is true, if label is undefined, it remains undefined.
if (treeTitleRender && (!labelInValue || (labelInValue && !label))) {
label = treeTitleRender(targetItem);
}
There was a problem hiding this comment.
对，不过这个可以优化一下。labelInValue && .label ~= undefined 就用自己的 label，反之再过一遍 titleRender
zombieJ
approved these changes
Dec 4, 2023
MadCcc
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ant-design/ant-design#45884