Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

ART still present in RN "core" #26

Open
jbrodriguez opened this issue Aug 8, 2019 · 7 comments
Open

ART still present in RN "core" #26

jbrodriguez opened this issue Aug 8, 2019 · 7 comments

Comments

@jbrodriguez
Copy link

Question

The Libraries/ART module is still present in FB as of 0.60.4

Some libraries (react-native-progress) depend on it.

Should they move to @react-native-community/art or there was the decision on ART turned around ?

@Esemesek
Copy link
Collaborator

Moving ART to this repository is a part of Lean Core effort. The module is already deprecated in React Native Core and you should get a warning message in the console. In one of the future releases, ART will be completely removed from the core.

@jeveloper
Copy link

@Esemesek Thanks! Could you clarify that current ART bundled in RN 59,60 is the same as in this repository ? Or is this repo already ahead of those bundled?

Thank you

@Esemesek
Copy link
Collaborator

@jeveloper This repo and ART from core are roughly the same. Only some minor refactors were merged.

@Monte47
Copy link

Monte47 commented Nov 13, 2019

So I have the correct dependency installed and everything works but I still get the warning. Is there any way to remove the warning or do I have to wait until it is removed from react core?

@Rotemy
Copy link

Rotemy commented Jan 2, 2020

So I have the correct dependency installed and everything works but I still get the warning. Is there any way to remove the warning or do I have to wait until it is removed from react core?

I think your project is still using the "old" RN version.

@laurentS
Copy link

laurentS commented Mar 9, 2020

Sorry to piggyback on this. I am moving an app from RN 0.59.10 to 0.60.6 and I got the following error message Tried to register two views with the same name ARTSurfaceView after I added @react-native-community/art to my dependencies. In yarn.lock I could see that both react-native and this package depend on art.
I tried removing @react-native-community/art from my package.json and import ART from react-native, and things work fine.
So I'm confused by the status of the Lean Core extraction of ART. The README seems to imply that the community package is already needed from RN 0.60 (even before, in fact). At what point are we supposed to actually make the transition?

laurentS added a commit to mapswipe/mapswipe that referenced this issue Mar 9, 2020
Same error message as in
https://stackoverflow.com/q/46613149/1138710

This seems to come from the fact that react-native still
dependson art ^0.10.0 which is also a dependency of
@react-native-community/art

Also see this issue in github at
react-native-art/art#26 (comment)
@Esemesek
Copy link
Collaborator

Esemesek commented Mar 9, 2020

ART in react-native is deprecated - it was deprecated in 0.60.x but it is still present on the master branch of react-native. You should receive warnings when importing it. It seems like ART is linked a couple of times in your project which causes an error. When using react-native >= 0.60.0 you should use this package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants