Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The getAudioRoutes changes the selected audio route #540

Open
2 of 3 tasks
nagyszili opened this issue Mar 8, 2022 · 1 comment · May be fixed by #557
Open
2 of 3 tasks

The getAudioRoutes changes the selected audio route #540

nagyszili opened this issue Mar 8, 2022 · 1 comment · May be fixed by #557

Comments

@nagyszili
Copy link

nagyszili commented Mar 8, 2022 •
edited
Loading

Bug report

  • I've checked the example to reproduce the issue.

  • Reproduced on:

  • Android

  • iOS

Description

If there is an active session and I call the getAudioRoutes() it changes the audio route, because there is a setCategory executed in the getAudioInputs

react-native-callkeep/ios/RNCallKeep/RNCallKeep.m

Line 516 in 1c798d6

BOOL isCategorySetted = [myAudioSession setCategory:AVAudioSessionCategoryPlayAndRecord withOptions:AVAudioSessionCategoryOptionAllowBluetooth error:&err];

https://developer.apple.com/documentation/avfaudio/avaudiosession/1616583-setcategory?language=objc

There is any workaround to avoid this type of behavior?

Steps to Reproduce

  1. Start a call
  2. Get the audioRoutes: call getAudioRoutes()
  3. Set an other audio route: call setAudioRoute()
  4. Get the audioRoutes again and this will change the setted audio route

Versions

- Callkeep: 4.3.2
- React Native: 0.64
- iOS: 15.2
- Android:
- Phone model: iPhone 6s Plus, iPhone 12
rcidt added a commit to net2phone/react-native-callkeep that referenced this issue Mar 31, 2022
@rcidt
fix(ios): The getAudioRoutes changes the selected audio route react-n…
a51cb74 
…ative-webrtc#540
@rcidt rcidt linked a pull request Mar 31, 2022 that will close this issue
Open
@rcidt
Copy link

rcidt commented Mar 31, 2022

I submitted a PR with a fix to this issue @nagyszili can you please test?

nagyszili added a commit to nagyszili/react-native-callkeep that referenced this issue Apr 1, 2022
@nagyszili
react-native-webrtc#540 fix to not change the setted audio route when…
96ebd25 
… getAudioRoute called
nagyszili added a commit to nagyszili/react-native-callkeep that referenced this issue Apr 4, 2022
@nagyszili
react-native-webrtc#540 setCategory to get audio routes when call is …
f55f55b 
…not connected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ios): The getAudioRoutes changes the selected audio route net2phone/react-native-callkeep
2 participants
@rcidt @nagyszili