Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request]: Add Testimonial Button #1523

Open
3 of 5 tasks
Shivam-Katare opened this issue Oct 1, 2024 · 13 comments
Open
3 of 5 tasks

✨ [Feature request]: Add Testimonial Button #1523

Shivam-Katare opened this issue Oct 1, 2024 · 13 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ⭐ goal: addition Addition of new feature hacktoberfest 🏁 status: ready for dev Ready for work

Comments

@Shivam-Katare
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There should be an option to add a testimonial directly from here, instead of clicking on the View All button and then adding it. Having the option here along with View All would be more convenient.

image

Describe the solution you'd like.

There should be a button or link for submitting a testimonial directly on the same page where the testimonials are displayed. This button could be placed next to or below the "View All" button. Users would be able to add a testimonial without navigating to a separate page.

Describe alternatives you've considered.

On the same page, we can add a Modal for Testimonials. Instead of redirecting to a different page, a modal could pop up when users click "Add Testimonial." This would allow users to add their feedback without leaving the current page.

Screenshot / Screenshare

No response

Additional context

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Shivam-Katare Shivam-Katare added 🚦status: awaiting triage Has not been triaged & therefore, not ready for work ⭐ goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository hacktoberfest labels Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Adil-Khan-N
Copy link
Contributor

Could you please assign this issue to me?

@priyankarpal
Copy link
Member

Could you please assign this issue to me?

Unfortunately, you can only work one issue at a time,so other contributors can work.

@day-lee
Copy link
Contributor

day-lee commented Oct 2, 2024

Can I work on this?

@Abhishek-90
Copy link
Contributor

Assigning to you @day-lee, Happy Coding!

@priyankarpal priyankarpal added 🏁 status: ready for dev Ready for work and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 2, 2024
@KrishDave1
Copy link
Contributor

This issue has not been resolved till now.Can I work on this issue?

@day-lee
Copy link
Contributor

day-lee commented Oct 10, 2024

@KrishDave1 Hi, I am currently working on it locally.

@PriteshKiri
Copy link
Contributor

Hey @day-lee ,

Any updates on the issue?

@day-lee
Copy link
Contributor

day-lee commented Oct 14, 2024

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem.
When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please?
Thanks,

image

@nilaygit-10721
Copy link

This issue has not been resolved till now.Can I work on this issue?

@PriteshKiri
Copy link
Contributor

@Shivam-Katare @Sachin-chaurasiya can you please check the suggestion by @day-lee ?

@PriteshKiri
Copy link
Contributor

@nilaygit-10721 the issue is under discussion. Can you please checkout other issues?

@Sachin-chaurasiya
Copy link
Member

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem. When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please? Thanks,

image

Hey @day-lee, in order to add a testimonial, users need to authenticate via GitHub. When they click the +Testimonial button, we retrieve the user token from Nhost and then display the add testimonial page. However, I noticed that the URL https://auth.nhost.run/v1/token is failing, which is why the add testimonial page isn't rendering properly. cc: @priyankarpal can you check why https://auth.nhost.run/v1/token is failing on production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ⭐ goal: addition Addition of new feature hacktoberfest 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

9 participants