-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add http-kit profile #46
Comments
👍 |
i took a basic reagent-template app and modified it to work with aleph/manifold... which probably satisfies the same itch you are looking for http-kit to scratch (async, websockets) ? https://github.com/mccraigmccraig/sparky-elephants the aleph server doesn't support the :auto-reload? option so i added a ring handler based auto-reload solution : https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/repl.clj i could port the changes back to an aleph profile in the reagent-template project if you are interested ? |
there's actually an easier way, you can use ring.middleware.reload as I'm doing in Luminus here. |
hmm, iirc i had problems with ring.middleware.reload not re-creating the handler chain, so i modified ring.middleware.reload ( https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/wrap_reload.clj ) and then recreate the handler chain on each request |
anyway, sounds like you don't need any help with aleph ;) |
Ah yes I've noticed that as well, route modifications don't get reflected either. I wouldn't mind adding aleph profile as well, just need time. :) |
if you would take a PR, i could do an aleph profile in the next few weeks ? |
that would be fantastic 👍 |
cool, i'll get on it when i have a moment :) |
@mccraigmccraig so have you had a moment since 2015 ?) Does somebody actually interested in this staff ? |
@atsman i haven't! i only went and started a new company 😬 |
No description provided.
The text was updated successfully, but these errors were encountered: