Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default human-oriented description for LoadError #315

Open
zhPavel opened this issue Jun 13, 2024 · 1 comment
Open

Add default human-oriented description for LoadError #315

zhPavel opened this issue Jun 13, 2024 · 1 comment
Labels
domain: loading & dumping need design study Research on architecture and API structure is required type: feature New feature or request

Comments

@zhPavel
Copy link
Member

zhPavel commented Jun 13, 2024

Currently, string representation of LoadError contains only fields without human-friendly description

@zhPavel zhPavel added type: feature New feature or request domain: loading & dumping need design study Research on architecture and API structure is required labels Jun 13, 2024
@bomzheg
Copy link

bomzheg commented Sep 6, 2024

Hello, I was confused when misreaded NoRequiredFieldsLoadError as NotRequiredFieldsLoadError and this mismatch gave the opposite result (something like "error by loading existing not required field" instead of "not found required field"). It was my bad, but it will be cool if error will be more clear.

I have two ideas to improve it:

  • rename error into something like RequiredFieldsNotFoundLoadError
  • add field to error, like text="This error maybe means that the field does not exist"

discussion about this was here: https://t.me/reagento_ru/77088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: loading & dumping need design study Research on architecture and API structure is required type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants