Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending bootstrap is not properly applied if connection is disconnected/reconnected #7707

Open
sync-by-unito bot opened this issue May 17, 2024 · 2 comments · May be fixed by #7983
Open

Pending bootstrap is not properly applied if connection is disconnected/reconnected #7707

sync-by-unito bot opened this issue May 17, 2024 · 2 comments · May be fixed by #7983
Assignees
@jbreams @danieltabacaru

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 17, 2024

We check for a pending bootstrap to apply when a sync::Session is activated, but not if the connection is disconnected/reconnected. This means that if you were in the middle of a bootstrap you may end up applying more data than necessary and could end up with some stale objects on the device.
@sync-by-unito Sync by Unito
Copy link
Author

sync-by-unito bot commented May 17, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2126

@sync-by-unito sync-by-unito bot assigned michael-wb and unassigned michael-wb Jun 21, 2024
@michael-wb michael-wb mentioned this issue Jun 21, 2024
Merged
2 tasks
@sync-by-unito Sync by Unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2024

➤ michael-wb commented:

If possible, the tests should also simulate the "fast reconnect" situation and verify partial bootstraps are removed and complete bootstraps are applied in that situation as well.

@danieltabacaru danieltabacaru linked a pull request Aug 14, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbreams jbreams

@danieltabacaru danieltabacaru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RCORE-2126 Clear incomplete bootstraps when the connection is established realm/realm-core
3 participants
@jbreams @danieltabacaru @michael-wb