Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize package.json #29

Open
chenglou opened this issue Sep 13, 2016 · 0 comments
Open

Sanitize package.json #29

chenglou opened this issue Sep 13, 2016 · 0 comments

Comments

@chenglou
Copy link
Collaborator

chenglou commented Sep 13, 2016

https://github.com/facebook/reason/blob/f7ba08b1b3b2e152d7d4f0b6bfe776008f780978/package.json#L49

This caused a duplicate merlin install (which might fail the compilation for npm-opam packages). The problems is that npm-opam/merlin resolves to https://github.com/npm-opam/merlin.git, which we use elsewhere. However, https://github.com/npm-opam/merlin.git and https://github.com/npm-opam/merlin are not the same.

We can warn related issues every time to run rebel (and it'll stay performant! No check done if package.json didn't change. Muahahahah Jenga). In general we can just throw all the package.json validation into Rebel I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant