Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refmt doesnt handle "//" comment syntax #99

Open
floscr opened this issue Jun 18, 2019 · 5 comments
Open

refmt doesnt handle "//" comment syntax #99

floscr opened this issue Jun 18, 2019 · 5 comments

Comments

@floscr
Copy link

floscr commented Jun 18, 2019

Refmt doesn't handle the new Comment Syntax from reasonml/reason#2254

refmt errors:
File "X.re", line 2, characters 0-2:
Error: 0: <syntax error>

Refmt version

Reason 3.3.3 @ fefe5e4d
@erykpiast
Copy link

Do you plan to address this issue? I can see this as well.

@jordwalke
Copy link
Member

Yes, it (and many other issues) are fixed in the new reason-cli package that is built from Azure on every commit.

@erykpiast
Copy link

@jordwalke Is there some other package to install? I have this issue with version [email protected].

@ianchanning
Copy link

As far as I can tell the last update to this repo was April 2018 and this bug was raised in June 2019, so I don't see how a fix could have been released after this. This bug is still there with 3.3.3 which appears to be the latest version.

@ianchanning
Copy link

ianchanning commented Nov 7, 2020

You can use bsrefmt instead of refmt. As mentioned in #103 this repo appears to be archived, it's not mentioned in the editor plugins anymore.

I commented in #103 that if you're using Vim you can run bsrefmt easily enough with the comment :!bsrefmt --in-place %

bsrefmt --version gives 3.6.0 and as far as I understand refmt was just the same base bsrefmt.

bsrefmt does fix this issue and handle single line comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants