Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for Rely #224

Open
kyldvs opened this issue Dec 18, 2019 · 7 comments
Open

Feedback for Rely #224

kyldvs opened this issue Dec 18, 2019 · 7 comments
Assignees

Comments

@kyldvs
Copy link
Contributor

kyldvs commented Dec 18, 2019

From @jaredly: https://github.com/jaredly/reason-language-server/blob/rely/test/RunTests.re#L11-L17

// Things I wish rely would do:
// - watch mode would be awesome
// - allow you to select a subset of the tests to run, from cli args
// - allow you to nest describes with beforeEach n stuff
// - display the sub-items of a describe as they're being run (at least sub-describes)
//   - it would be fine to use readline to replace them one after another, but I just want
//     feedback that things are happening.

Let's make sure we have issues tracking these and address what we can.

@kyldvs kyldvs assigned kyldvs and bandersongit and unassigned kyldvs Dec 18, 2019
@jaredly
Copy link

jaredly commented Dec 18, 2019

haha thanks :D

@mikaello
Copy link

Related thread regarding the first point: https://reasonml.chat/t/running-rely-test-framework-in-watch-mode/1710

@kyldvs
Copy link
Contributor Author

kyldvs commented Dec 18, 2019

// - allow you to select a subset of the tests to run, from cli args

I think we had to enable something like this for some of our internal infra, but I believe our solution is just to run everything (because it's fast enough) and then only report on the tests specified by CLI args

@davesnx
Copy link
Member

davesnx commented Dec 19, 2019

That would be awesome!

@bandersongit
Copy link
Contributor

Thanks for filing this @kyldvs and for the awesome feedback @jaredly

  • watch mode is definitely something that is on the radar, as Jordan discussed in the linked thread I think we are looking into integrating that in esy to have a nice cross platform solution. The watchman script in that thread works as well.

  • Running a subset of tests is definitely something I plan on building in and will bump up in priority. As Kyle said we are currently doing this in a hacky way internally, but I've built some infrastructure that should make actually supporting this fairly straightforward.

  • @jaredly Can you elaborate more on your usecase for nesting lifecycle functions with describes?

  • I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

facebook-github-bot pushed a commit that referenced this issue Feb 11, 2020
Summary:
Addresses part of #224

Fairly intuitive filtering implementation as well as integration with our internal CLI library.

![image](https://user-images.githubusercontent.com/5252755/74194208-b5680380-4c0d-11ea-8e74-b99e5ee5a842.png)
![image](https://user-images.githubusercontent.com/5252755/74194244-c1ec5c00-4c0d-11ea-9406-6c6aa09ee6ad.png)
Pull Request resolved: #235

Differential Revision: D19827404

Pulled By: bandersongit

fbshipit-source-id: bca7c71f33af48e7cf5dc6a6e1ea1910be5da15d
@lessp
Copy link

lessp commented May 2, 2020

I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

Would this be mean seeing each test-case (a verbose-mode if you will), something like:

[Suite 2]
- handles foo
- handles bar
[Suite 2]
- handles foo
- handles bar

If so, I'd also very much like this feature! 👍

@bandersongit
Copy link
Contributor

I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

Would this be mean seeing each test-case (a verbose-mode if you will), something like:

[Suite 2]
- handles foo
- handles bar
[Suite 2]
- handles foo
- handles bar

If so, I'd also very much like this feature! 👍

That's the idea. Noted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants